Tree experiment #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation for inverse
Add --all-targets
Merged from latest master at:
https://github.com/sfackler/cargo-tree
syn seems to have some problems parsing at least one of the indirect dependencies of this project, will add som fault tolerance to allow partial results being reported to the user and try updating syn.
This was referenced Jun 20, 2018
Closed
(cherry-picking commit 68495c2)
(cherry-picking commit 7da84b0)
An expression like `str::from_utf8_unchecked(bytes)` should be counted
as one unsafe expression. That is, just `str::from_utf8_unchecked` and
`bytes` by themselves are not expressions that can meaningfully be
considered unsafe. A way to see this is that there would never be a
reason to write:
unsafe { f }(unsafe { x })
|
Holy crap. Are you sure you don't want to just make your own crate? 😁 |
|
I just pushed up cherry picking from master, pretty sure it's in sync again.
Maybe? If you don't think this is the direction for cargo-osha I will make a new repos and crate. I don't feel the need to have it under my github user though, it's like max 10% that's my code in this PR, the rest is the original cargo-osha on top of cargo-tree. :) |
Trying to please github merge.
|
Conflicts fixed. Feel free to review, merge or just close :) |
|
I did what you suggested and created a new project: https://crates.io/crates/cargo-geiger If you want to merge the projects later that would be totally fine with me. Thanks for the nice and simple code btw! 👍 Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #3
Solves: #2
This is not ready to merge, I took a whole lot of liberty with this PR
and it is missing the commits from the last 24 hours or so.The history is a bit unexpected since I merged in
cargo-treeas boiler plate, most of it is still there. That seemed like a reasonable approach to me sincecargo-treealready had the recursive dependency walking in place but was not packaged up as a library and needed some modifications.Does this PR seem like a good direction at all for cargo-osha?
What should change?
What is missing?