1.14.3 protocol support (490) #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Copying v1_14_3 from v1_14_2, able to login:
but there are some protocol changes: https://wiki.vg/index.php?title=Pre-release_protocol&type=revision&diff=14826&oldid=14794 |
|
Only packet change seems to be adding "can restock" bool to TradeList, but looking at the current implementation versus documentation, we are missing all the new fields in 1.14.x from 1.13.2 (Trade: xp, special price, prince multiplier, and fields after trade: villager level, experience, is regular villager, not to mention can restock). May have gotten away with it because this packet wasn't seen during testing, but should go back to when the new fields were added and add to older protocol versions. TradeList was first added for 452 (19w02a): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14515#Trade_List. Next is supported 1.14 (477): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14752#Trade_List which adds the six new fields (all but can restock, which is new in 1.14.3). |
TradeList only had fields from the prerelease: 19w02a (452): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14515#Trade_List add the six missing fields present in the 1.14 release: 1.14 (477): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14752#Trade_List Note this breaks 19w02a TradeList parsing, can be fixed by splitting the packet for 19w02a/1.14 if needed later.
iceiix
added a commit
that referenced
this pull request
Feb 1, 2020
* Copy v1_14_3 from v1_14_2 * Add protocol 490 for v1_14_3 * Add missing 1.14 release TradeList packet fields TradeList only had fields from the prerelease: 19w02a (452): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14515#Trade_List add the six missing fields present in the 1.14 release: 1.14 (477): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14752#Trade_List Note this breaks 19w02a TradeList parsing, can be fixed by splitting the packet for 19w02a/1.14 if needed later. * Add TradeList_WithRestock variant with new can_restock field
iceiix
added a commit
that referenced
this pull request
Feb 1, 2020
* Copy v1_14_3 from v1_14_2 * Add protocol 490 for v1_14_3 * Add missing 1.14 release TradeList packet fields TradeList only had fields from the prerelease: 19w02a (452): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14515#Trade_List add the six missing fields present in the 1.14 release: 1.14 (477): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14752#Trade_List Note this breaks 19w02a TradeList parsing, can be fixed by splitting the packet for 19w02a/1.14 if needed later. * Add TradeList_WithRestock variant with new can_restock field
iceiix
added a commit
that referenced
this pull request
Feb 1, 2020
* Copy v1_14_3 from v1_14_2 * Add protocol 490 for v1_14_3 * Add missing 1.14 release TradeList packet fields TradeList only had fields from the prerelease: 19w02a (452): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14515#Trade_List add the six missing fields present in the 1.14 release: 1.14 (477): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14752#Trade_List Note this breaks 19w02a TradeList parsing, can be fixed by splitting the packet for 19w02a/1.14 if needed later. * Add TradeList_WithRestock variant with new can_restock field
iceiix
added a commit
that referenced
this pull request
Feb 2, 2020
* Copy v1_14_3 from v1_14_2 * Add protocol 490 for v1_14_3 * Add missing 1.14 release TradeList packet fields TradeList only had fields from the prerelease: 19w02a (452): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14515#Trade_List add the six missing fields present in the 1.14 release: 1.14 (477): https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14752#Trade_List Note this breaks 19w02a TradeList parsing, can be fixed by splitting the packet for 19w02a/1.14 if needed later. * Add TradeList_WithRestock variant with new can_restock field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://minecraft.gamepedia.com/Java_Edition_1.14.3
https://wiki.vg/Protocol_version_numbers
1.14.3: https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14826
1.14.2: https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14794
enhances #18
diffs 1.14.3 vs 1.14.2: https://wiki.vg/index.php?title=Pre-release_protocol&type=revision&diff=14826&oldid=14794