Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.14.4 protocol support (498) #207

Merged
merged 5 commits into from
Aug 12, 2019
Merged

1.14.4 protocol support (498) #207

merged 5 commits into from
Aug 12, 2019

Conversation

iceiix
Copy link
Owner

@iceiix iceiix commented Aug 11, 2019 •
edited

@iceiix iceiix added the enhancement New feature or request label Aug 11, 2019
@iceiix iceiix mentioned this pull request Aug 11, 2019
Closed
@iceiix
Copy link
Owner Author

iceiix commented Aug 11, 2019 •
edited

The wiki diffs https://wiki.vg/index.php?title=Pre-release_protocol&type=revision&diff=14870&oldid=14826 have a lot of changes, but most are from https://wiki.vg/index.php?title=Pre-release_protocol&type=revision&diff=14853&oldid=14852 "Clientbound: Fix packet order (this got messed up when the IDs were re-ordered, I think?)", reformatting not actual protocol changes.

New packet 0x5c first documented in https://wiki.vg/index.php?title=Pre-release_protocol&type=revision&diff=14851&oldid=14849, last revised to Acknowledge Player Digging.

New field "demand": https://wiki.vg/index.php?title=Pre-release_protocol&type=revision&diff=14862&oldid=14856 "Mark the new "Demand" flag as an added field" and "1.14.4-pre5. See MC-151282 for the demand field" / MC-151282 - Villager trade GUI does not show the correct price on servers if trade demand is high

@iceiix iceiix merged commit 4509916 into master Aug 12, 2019
@iceiix iceiix deleted the 1.14.4 branch August 12, 2019 00:26
iceiix added a commit that referenced this pull request Feb 1, 2020
@iceiix
1.14.4 protocol support (498) (#207)
73125bc 
* Add protocol 498 for 1.14.4

* Add 0x5c AcknowledgePlayerDigging packet, https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14870#Acknowledge_Player_Digging

* Add new demand field in protocol::Trade

https://wiki.vg/index.php?title=Pre-release_protocol&type=revision&diff=14862&oldid=14856
MC-151282 - Villager trade GUI does not show the correct price on servers if trade demand is high
iceiix added a commit that referenced this pull request Feb 1, 2020
@iceiix
1.14.4 protocol support (498) (#207)
f0bba32 
* Add protocol 498 for 1.14.4

* Add 0x5c AcknowledgePlayerDigging packet, https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14870#Acknowledge_Player_Digging

* Add new demand field in protocol::Trade

https://wiki.vg/index.php?title=Pre-release_protocol&type=revision&diff=14862&oldid=14856
MC-151282 - Villager trade GUI does not show the correct price on servers if trade demand is high
iceiix added a commit that referenced this pull request Feb 1, 2020
@iceiix
1.14.4 protocol support (498) (#207)
f2f3be8 
* Add protocol 498 for 1.14.4

* Add 0x5c AcknowledgePlayerDigging packet, https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14870#Acknowledge_Player_Digging

* Add new demand field in protocol::Trade

https://wiki.vg/index.php?title=Pre-release_protocol&type=revision&diff=14862&oldid=14856
MC-151282 - Villager trade GUI does not show the correct price on servers if trade demand is high
iceiix added a commit that referenced this pull request Feb 2, 2020
@iceiix
1.14.4 protocol support (498) (#207)
a095e26 
* Add protocol 498 for 1.14.4

* Add 0x5c AcknowledgePlayerDigging packet, https://wiki.vg/index.php?title=Pre-release_protocol&oldid=14870#Acknowledge_Player_Digging

* Add new demand field in protocol::Trade

https://wiki.vg/index.php?title=Pre-release_protocol&type=revision&diff=14862&oldid=14856
MC-151282 - Villager trade GUI does not show the correct price on servers if trade demand is high
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@iceiix