New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: return Error instaed of ArrowError for to_arrow #123

Merged

Xuanwo merged 1 commit into icelake-io:main from ZENOTME:error

Jul 30, 2023

Contributor

ZENOTME commented Jul 30, 2023 •

edited

If we return ArrowError, it will cause user have to depend on arrow_schema sometimes.

And I find that implementation of to_arrow always return Ok(), can we directly implement from rather than try_from?


          return Error instaed of ArrowError to avoid user's dependency for arr…

16b217b

…ow_schema

ZENOTME requested a review from Xuanwo

July 30, 2023 04:03

Xuanwo merged commit cfb81eb into icelake-io:main

3 checks passed

ZENOTME deleted the error branch

July 31, 2023 03:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment