Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refine StructValue #135

Merged
merged 1 commit into from
Aug 2, 2023
Merged

refactor: refine StructValue #135

merged 1 commit into from
Aug 2, 2023

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Aug 2, 2023 •
edited

This PR:

  1. refactor StructValue to make it support optional field.
  2. Use a more compact way to store the StructValue.
  3. Add a StructValueBuilder

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Aug 2, 2023

Maybe null-bitmap + struct buidler is better.🤔

@ZENOTME ZENOTME changed the title fix: support optional field in struct refactor: refine StructValue Aug 2, 2023
@ZENOTME ZENOTME merged commit aece12b into main Aug 2, 2023
4 checks passed
@ZENOTME ZENOTME deleted the struct branch August 2, 2023 06:20
liurenjie1024
liurenjie1024 reviewed Aug 2, 2023
View reviewed changes
icelake/src/types/in_memory.rs
Comment on lines +305 to +306
field_id: Vec<i32>,
field_name: Vec<String>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just keep a Box<StructType>? We may have many values for same type, and storing this may lead to memory leak.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. I will do it in next PR.

@ZENOTME ZENOTME mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZENOTME @liurenjie1024 @Xuanwo