Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: support nest field look up #158

Merged
merged 1 commit into from
Aug 23, 2023
Merged

refactor: support nest field look up #158

merged 1 commit into from
Aug 23, 2023

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Aug 23, 2023

This PR:

  1. use FieldRef instead of Field so that to save cost in look_up map
  2. support nest field look up

1. use fieldref instead of field in struct
745c6c3 
2. support nested field look up
@ZENOTME ZENOTME requested review from liurenjie1024 and Xuanwo and removed request for liurenjie1024 August 23, 2023 05:00
liurenjie1024
liurenjie1024 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liurenjie1024 liurenjie1024 merged commit aa9c09a into icelake-io:main Aug 23, 2023
3 checks passed
@ZENOTME ZENOTME deleted the field branch August 23, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZENOTME @liurenjie1024 @Xuanwo