Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: support to select column by source coulumn id #159

Merged
merged 1 commit into from
Aug 24, 2023
Merged

refactor: support to select column by source coulumn id #159

merged 1 commit into from
Aug 24, 2023

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Aug 24, 2023

This PR:

  1. store column id in metadata instead of dict id.
  2. support to select column in arrow by column id.

liurenjie1024
liurenjie1024 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

icelake/tests/insert_tests.rs Outdated

let init_sqls = vec![
"CREATE SCHEMA IF NOT EXISTS s1".to_string(),
format!("DROP TABLE IF EXISTS s1.{}", table_name),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
format!("DROP TABLE IF EXISTS s1.{}", table_name),
format!("DROP TABLE IF EXISTS s1.{table_name}"),

icelake/tests/insert_tests.rs Outdated
format!("DROP TABLE IF EXISTS s1.{}", table_name),
format!(
"
CREATE TABLE s1.{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CREATE TABLE s1.{}
CREATE TABLE s1.{table_name}

@ZENOTME ZENOTME force-pushed the col_id branch 3 times, most recently from 6c410a7 to 0a388f6 Compare August 24, 2023 10:35
@ZENOTME ZENOTME force-pushed the col_id branch 2 times, most recently from febd2ed to 765d7e1 Compare August 24, 2023 10:46
@ZENOTME ZENOTME merged commit aeba46c into icelake-io:main Aug 24, 2023
3 checks passed
@ZENOTME ZENOTME deleted the col_id branch August 24, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZENOTME @liurenjie1024 @Xuanwo