Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support task writer #75

Merged
merged 1 commit into from
Jul 6, 2023
Merged

feat: support task writer #75

merged 1 commit into from
Jul 6, 2023

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Jul 6, 2023

This PR provide the task writer interface disscussed in #74.

We didn't support partition now, so it basically a wrapper of data file writer.

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Jul 6, 2023

cc @Xuanwo @liurenjie1024

Copy link
Contributor

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's moving on.

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 6, 2023

I'm waiting for the full picture that how users will use icelake to write data. Before that, I will merge PRs without reviewing it's API details.

@Xuanwo Xuanwo marked this pull request as ready for review July 6, 2023 10:32
@Xuanwo Xuanwo merged commit c3108df into icelake-io:main Jul 6, 2023
3 checks passed
@ZENOTME ZENOTME deleted the task_writer branch July 6, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants