Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support open_with_operator #76

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Jul 10, 2023

I try to using Table in RisingWave and find that use uri to create table is not convinient.

For example, load a table using s3, we get the config like

struct config {
    path: &str,
    access_key: &str,
    endpoint: &str
}

If we only support to create table using uri, we need to serialize the config into uri and deserialize in icelake.

So in this case, may be having a open_with_operator is better.

How do you think? @liurenjie1024 @Xuanwo

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liurenjie1024 liurenjie1024 merged commit 0e31ea1 into icelake-io:main Jul 10, 2023
3 checks passed
@ZENOTME ZENOTME deleted the open branch July 11, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants