Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Rename some data structures. #77

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fix: Rename some data structures. #77

merged 2 commits into from
Jul 11, 2023

Conversation

liurenjie1024
Copy link
Contributor

This pr rename some data structures to better align to iceberg spec.

  1. Add a struct ManifestList
  2. Rename ManifestList to ManifestListEntry
  3. Add a struct ManifestFile
  4. Rename ManifestFile to ManifestEntry

@liurenjie1024
Copy link
Contributor Author

cc @ZENOTME

Xuanwo
Xuanwo approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks！

@Xuanwo Xuanwo merged commit 2c22d60 into icelake-io:main Jul 11, 2023
3 checks passed
@liurenjie1024 liurenjie1024 deleted the renjie/manifest_list_multi_entry branch July 11, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liurenjie1024 @Xuanwo