Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Convert iceberg schema to avro schema #88

Merged
merged 5 commits into from
Jul 13, 2023
Merged

feat: Convert iceberg schema to avro schema #88

merged 5 commits into from
Jul 13, 2023

Conversation

liurenjie1024
Copy link
Contributor

This is a preparation for writing the manifest file.

@liurenjie1024
Copy link
Contributor Author

cc @ZENOTME

Xuanwo
Xuanwo reviewed Jul 13, 2023
View reviewed changes
src/datatypes/avro.rs Outdated Show resolved Hide resolved
src/types/in_memory.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

src/types/to_avro.rs Show resolved Hide resolved
@liurenjie1024
Copy link
Contributor Author

Let's hold on the merge, I need to add some tests 🤪

@liurenjie1024 liurenjie1024 merged commit b49df79 into icelake-io:main Jul 13, 2023
3 checks passed
@liurenjie1024 liurenjie1024 deleted the renjie/types branch July 13, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liurenjie1024 @Xuanwo