Fixed check for missing script #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @kmalakoff. Thanks for submitting this PR 😊 This really is a careless mistake that I couldn't have spot it out for over an year! I guess my test case isn't really covering the whole scenario, however I didn't manage to find a webpack configuration that can reproduce the error. I would be grateful if you could share me your webpack configuration, so that I can enhance my tests. |
icelam
approved these changes
Jul 4, 2021
5 tasks
|
No worries! There's an example here, but it is is complicated to extract into a nice little test case. Thank you for the merge and re-publish. I appreciate your efforts |
|
Thanks for sharing the information. I will take a look and see how I can reproduce the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a check for tag, but it should have been for asset. The plugin crashed the first time I used it and it looks like a simple logic error.
How has this been tested?
I ran your tests and they passed
Types of changes
featfixrefactortestRemarks
N/A