Requirements not installed

[dlilien]

On clean installs, requirements.txt is ignored if icepack is installed with firedrake. I don't think this happens with pip/from source. But if a new user follows instructions on https://icepack.github.io/install/ the test will fail and they will be missing:

geojson, gmsh, meshio>=3.3.1, MeshPy, netCDF4, pooch>=1.0.0, pygmsh<=6.1.1, scipy, shapely, tqdm, and rasterio.

I did not fix this, since I am not sure if there is a better solution than just adding
pip install -r requirements.txt
before the pytest line on the instructions.

[jkingslake]

Hi,
Congratulations on making such an impressive looking package! I am really excited to start using it!

I have a similar issue with a clean install on a mac following the instructions here https://icepack.github.io/install/.

When I run ice-shelf_test.py I get a module not found error for firedrake:

============================= test session starts ==============================
platform darwin -- Python 3.7.4, pytest-5.2.1, py-1.8.0, pluggy-0.13.0
rootdir: /Users/jkingslake/firedrake/src/icepack
plugins: arraydiff-0.3, remotedata-0.3.2, doctestplus-0.4.0, openfiles-0.4.0
collected 0 items / 1 errors                                                   

==================================== ERRORS ====================================
___________________ ERROR collecting test/ice_shelf_test.py ____________________
ImportError while importing test module '/Users/jkingslake/firedrake/src/icepack/test/ice_shelf_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test/ice_shelf_test.py:15: in <module>
    import firedrake
E   ModuleNotFoundError: No module named 'firedrake'
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.11s ===============================

It is probably me doing something wrong, but I am not sure what.

Any help would be much appreciated!

[danshapero]

@dlilien I can't believe I forgot to get to this so long, but icepack/icepack.github.io@39283c8 adds the instruction to the icepack install page. We had to remove installing everything in requirements.txt from the Firedrake install script because other things broke, so for now this extra step is necessary, but it should all get fixed soon.

@jkingslake Thanks for your interest! I think what you're encountering is a separate issue; I'll close this for now but I've just sent you an email.