-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements not installed #98
Comments
Hi, I have a similar issue with a clean install on a mac following the instructions here https://icepack.github.io/install/. When I run ice-shelf_test.py I get a module not found error for firedrake:
It is probably me doing something wrong, but I am not sure what. Any help would be much appreciated! |
@dlilien I can't believe I forgot to get to this so long, but icepack/icepack.github.io@39283c8 adds the instruction to the icepack install page. We had to remove installing everything in requirements.txt from the Firedrake install script because other things broke, so for now this extra step is necessary, but it should all get fixed soon. @jkingslake Thanks for your interest! I think what you're encountering is a separate issue; I'll close this for now but I've just sent you an email. |
On clean installs, requirements.txt is ignored if icepack is installed with firedrake. I don't think this happens with pip/from source. But if a new user follows instructions on https://icepack.github.io/install/ the test will fail and they will be missing:
geojson, gmsh, meshio>=3.3.1, MeshPy, netCDF4, pooch>=1.0.0, pygmsh<=6.1.1, scipy, shapely, tqdm, and rasterio.
I did not fix this, since I am not sure if there is a better solution than just adding
pip install -r requirements.txt
before the
pytest
line on the instructions.The text was updated successfully, but these errors were encountered: