Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin for change only AndroidManifest location #49

Closed
Alex009 opened this issue Jun 26, 2021 · 0 comments
Closed

Add plugin for change only AndroidManifest location #49

Alex009 opened this issue Jun 26, 2021 · 0 comments
Assignees
@Alex009
Labels
enhancement New feature or request
Milestone
0.12.0

Comments

@Alex009
Copy link
Member

Alex009 commented Jun 26, 2021

if we change all android directories then android gradle plugin can broke own logic of databinding/buildflavours so we should give way to setup MPP libs without big configuration but with correctly located manifest.

KMM template in android studio now create this config:

android {
    sourceSets["main"].manifest.srcFile("src/androidMain/AndroidManifest.xml")
}

we should do it in plugin dev.icerock.mobile.multiplatform.android-manifest
@Alex009 Alex009 added the enhancement New feature or request label Jun 26, 2021
@Alex009 Alex009 added this to the 0.12.0 milestone Jun 26, 2021
@Alex009 Alex009 self-assigned this Jun 26, 2021
Alex009 added a commit that referenced this issue Jun 26, 2021
@Alex009
#49 add android manifest plugin
77cc823
Alex009 added a commit that referenced this issue Jun 26, 2021
@Alex009
#49 #50 migrate mobile targets plugin to use new android plugins
f2a218c
Alex009 added a commit that referenced this issue Jun 26, 2021
@Alex009
Merge pull request #51 from icerockdev/#49-#50-android-plugins
5455aa8 
#49 #50 android plugins
@Alex009 Alex009 mentioned this issue Jun 26, 2021
Merged
@Alex009 Alex009 closed this as completed Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex009 Alex009

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
1 participant
@Alex009