Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Coroutines don't resume if picker screen was closed #48

Closed
Dorofeev opened this issue Apr 21, 2021 · 0 comments · Fixed by #49
Closed

[iOS] Coroutines don't resume if picker screen was closed #48

Dorofeev opened this issue Apr 21, 2021 · 0 comments · Fixed by #49
Assignees
@Dorofeev
Labels
bug Something isn't working
Milestone
0.8.1

Comments

@Dorofeev
Copy link
Contributor

When using MediaPickerController for pick image from gallery or for pick file, if you close picker screen with swipe down (available since iOS 13 for modal presented controllers), coroutine wouldn't resume.

In this case coroutine should be resumed with CanceledException
@Alex009 Alex009 added the bug Something isn't working label Apr 21, 2021
@Alex009 Alex009 added this to the 0.8.1 milestone Apr 22, 2021
Dorofeev added a commit to Dorofeev/moko-media that referenced this issue Apr 22, 2021
@Dorofeev
icerockdev#48 added handling of close picker screen
3876bd0
Alex009 added a commit that referenced this issue Apr 22, 2021
@Alex009
Merge pull request #49 from Dorofeev/#48-picker-close-handle
46bbdfe 
#48 added handling of close picker screen
@Alex009 Alex009 linked a pull request Apr 22, 2021 that will close this issue
#48 added handling of close picker screen #49
Merged
@Alex009 Alex009 closed this as completed Apr 22, 2021
@Dorofeev Dorofeev mentioned this issue Apr 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dorofeev Dorofeev

Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.1
Development

Successfully merging a pull request may close this issue.

#48 added handling of close picker screen Dorofeev/moko-media
2 participants
@Dorofeev @Alex009