Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebSockets support to ktor's Ios HttpClientEngine #149

Closed
Tracked by #19
Alex009 opened this issue Jul 24, 2021 · 2 comments · Fixed by #158
Closed
Tracked by #19

Add WebSockets support to ktor's Ios HttpClientEngine #149

Alex009 opened this issue Jul 24, 2021 · 2 comments · Fixed by #158
Assignees
@anton6tak
Labels
enhancement New feature or request
Milestone
0.18.0

Comments

@Alex009
Copy link
Member

Alex009 commented Jul 24, 2021

We already can use ktor-client to websockets communications on android (with ktor-client-okhttp), but on iOS it's disabled. Here proof of concept project where implemented iOS websockets support for ktor HttpClientEngine on iOS - https://github.com/Alex009/ktor-client-ios-websockets

in this issue we should add into moko-network library ability to create HttpClientEngine with websockets support
@Alex009 Alex009 added the enhancement New feature or request label Jul 24, 2021
@Alex009 Alex009 added this to the 0.17.0 milestone Jul 24, 2021
This was referenced Jul 24, 2021
Open
Closed
@Alex009 Alex009 mentioned this issue Aug 3, 2021
Closed
1 task
@y9san9
Copy link
Collaborator

y9san9 commented Aug 5, 2021

Add support for ping configuration in native client

@Alex009
Copy link
Member Author

Alex009 commented Aug 8, 2021

https://developer.apple.com/documentation/foundation/nsurlsessionwebsockettask require iOS 13.0

@anton6tak anton6tak linked a pull request Aug 25, 2021 that will close this issue
#149 add web sockets support ios #158
Merged
@Alex009 Alex009 modified the milestones: 0.17.0, 0.18.0 Mar 4, 2022
Alex009 added a commit that referenced this issue Jul 16, 2022
@Alex009
Merge pull request #158 from anton6tak/#149-add-WebSockets-support-Ios
c92058b 
#149 add web sockets support ios
@Alex009 Alex009 closed this as completed Jul 16, 2022
@Alex009 Alex009 mentioned this issue Jul 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anton6tak anton6tak

Labels
enhancement New feature or request
Projects
MOKO backlog
Status: No status
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

#149 add web sockets support ios
3 participants
@Alex009 @y9san9 @anton6tak