Add error message at attempt to get fragmentManager #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex009
requested changes
Apr 15, 2024
| @@ -21,7 +21,9 @@ actual fun BindEffect(permissionsController: PermissionsController) { | |||
| val context: Context = LocalContext.current | |||
|
|
|||
| LaunchedEffect(permissionsController, lifecycleOwner, context) { | |||
| val fragmentManager: FragmentManager = (context as FragmentActivity).supportFragmentManager | |||
| val fragmentManager: FragmentManager = checkNotNull(context as? FragmentActivity) { | |||
| "$context context is not instance of FragmentActivity" | |||
There was a problem hiding this comment.
we should describe here how to fix it, not just show error just like current
|
we will complete #114 instead of this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #106