Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: getting string with escaped single quote "\'" returns string with the escape character included #382

Closed
luca992 opened this issue Sep 13, 2022 · 1 comment · Fixed by #426
Closed

JS: getting string with escaped single quote "\'" returns string with the escape character included #382

luca992 opened this issue Sep 13, 2022 · 1 comment · Fixed by #426
Labels
bug Something isn't working
Milestone
0.21.0

Comments

@luca992
Copy link
Contributor

luca992 commented Sep 13, 2022

For example

<string name="were">we\'re</string>
var stringsProvider : JsStringProvider = MR.stringsLoader.getOrLoad()
val wereString = StringDesc.Resource(MR.strings.were).localized(stringsProvider)
println(wereString)

On JS will print we\'re but using resources-compose on android and jvm will print we're
@Alex009 Alex009 added the bug Something isn't working label Sep 14, 2022
@Alex009 Alex009 added this to the 0.20.2 milestone Sep 14, 2022
@Alex009 Alex009 linked a pull request Mar 3, 2023 that will close this issue
use forward slash when generating assets for file paths in js #426
Merged
@Alex009
Copy link
Member

Alex009 commented Mar 3, 2023

will be released in 0.21.0

@Alex009 Alex009 closed this as completed Mar 3, 2023
@Alex009 Alex009 mentioned this issue Mar 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
MOKO backlog
Status: No status
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

use forward slash when generating assets for file paths in js Qawaz/moko-resources
2 participants
@luca992 @Alex009