Minor documentation improvements #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Apr 11, 2023
| several built-it interceptors for logging, compression and more. | ||
|
|
||
| - **Pipeline**\ | ||
| A [pipeline](pipeline) forwards a request through interceptors and a final invoker registered with this pipeline. |
There was a problem hiding this comment.
Is final the same as leaf?
If yes, then we should use the same term.
If no, then what's the difference?
There was a problem hiding this comment.
I fixed the test to use leaf instead of final.
This was referenced Apr 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements accepted fixes from #30.
One thing which isn't clear to me... We tie outgoing/incoming request "features" to C#. Do we anticipate it to be specific to the C# implementation of IceRPC? It would think this is more general IceRPC concept that will be available in other language mappings.