-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate "geospatial.py" module with new "validate_spatial" class #321
Comments
From @JessicaS11's comment on #318 - It is worth thinking about how the spatial portion might be (potentially) combined with the geospatial.py module as well as utilizing existing libraries to the extent possible to validate and refine inputs. For instance, using Shapely:
Both fmtbox and b_fmtbox will output (-55.0, 68.0, -48.0, 71.0) as the valid, correctly formatted bounding box. In this case, we could eliminate completely the check + user warning that they entered the coordinates in the wrong order. However, this DOES NOT deal with #151 (which I think is due to #117) and would actually make cross-dateline queries more challenging, so we should keep that in mind before implementing this route (perhaps requiring the user to manually specify via keyword they intend to cross the dateline with their query and then handling the request accordingly?). |
Decided to make this a separate issue so I can look into it after the "first" version of the |
Issue has been resolved with PR #322 |
No description provided.
The text was updated successfully, but these errors were encountered: