Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New eduardok smbclient option: smbclient_client_protocols #99

Closed
mmattel opened this issue Jan 20, 2021 · 4 comments
Closed

New eduardok smbclient option: smbclient_client_protocols #99

mmattel opened this issue Jan 20, 2021 · 4 comments

Comments

@mmattel
Copy link
Contributor

mmattel commented Jan 20, 2021

Hi @icewind1991
I just want to make you aware of a possible upcoming new smb client option which might need a addon to your code (which I do not know, but anyways). Pls see eduardok/libsmbclient-php#53

@mmattel mmattel changed the title possible new eduardok smbclient option New eduardok smbclient option: smbclient_client_protocols Jan 21, 2021
@mmattel
Copy link
Contributor Author

mmattel commented Jan 21, 2021

Update, great news: eduardok has released this feature which is now officially available including PECL (1.0.2)
Could you take a look and make this also available in your wrapper, so it can be used if existant?

For details see the referenced issue and the updated readme on eduardoks repo.

These protocol options overwrite protocol definitions used in smb.conf and can be therefore used on a connection basis.

It would be important to be able to set following option and restrict thereby the protocols used:
native smbclient -->
--option='client min protocol=<protocol_min>'
--option='client max protocol=<protocol_max>'
or
libsmbclient-php -->
smbclient_client_protocols($state, '<protocol_min>', '<protocol_max>')

Where <protocol_min|max> is one of the available protocols like NT1 or SMB2 or SMB3 ect.
Note, that I also have seen SMB2_02 as necessary parameter. Therefore the string needs to be flexible...

@jvillafanez fyi

@icewind1991
Copy link
Owner

Fixed with 3.3.0

@mmattel
Copy link
Contributor Author

mmattel commented Mar 3, 2021

@icewind1991 thanks for implementing.
Q: is it necessary to always set both (min and max) values, or can you set min only or max only?
I have not found any info about that.

@icewind1991
Copy link
Owner

Setting only one should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants