Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websocket support #21

Merged
merged 2 commits into from
Apr 22, 2018
Merged

Add websocket support #21

merged 2 commits into from
Apr 22, 2018

Conversation

stanhebben
Copy link

Glad to have encountered this little gem.

However, I needed websockets, and this tool doesn't support them.

So I added it.

@icflorescu icflorescu merged commit c9426b6 into icflorescu:master Apr 22, 2018
@icflorescu
Copy link
Owner

Thanks a lot, @stanhebben! I haven't been using IIS (or iisexpress-proxy) for a long time and - although lots of people complained about the lack of support for WebSockets, no one else would come up with a PR so far.

Merged and published on npm registry as v1.4.0. There's also a note in the README mentioning you; if you have anything to add (such as a brief description of a usage scenario), please feel free to add it and I'll republish it.

Thanks again, and - btw - would you be interested in becoming a co-maintainer for this repo?

@stanhebben
Copy link
Author

I'll think about it. I will be working with IIS Express for the foreseeable future and there will be uses for the proxy from time to time. However, my schedule is very busy, so I don't know if I'll be able to spend any additional time and mental resources to engage into testing and fixing the issues that come up.

However, for the time being, if there's bugs or issues I'm encountering I will be glad to provide respective PRs for them.

@icflorescu
Copy link
Owner

It's open-source, free and non-profit, so it comes with no obligations :-). About time & mental resources to spend - this is definitely not lodash or react; it has less than 350 stars here and barely over 650 downloads per month on npm, so there's not much activity around it. Just the occasional PR once every six months or so - 4 including yours since 2015. So it's not about time or resources (I'm in the same situation as you - don't have a lot to spare), it's just that on the long term it would be safer for the repo to have more than just one collaborator, and I'd be happier to share the access with somebody that uses the project (or has used it at some point), that's all. And by coming up with the PR above you already did more than what 99% of the users do :-)

Thanks again and let me know if I can add you as a collaborator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants