Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cookies options #113

Merged
merged 1 commit into from
Feb 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 26 additions & 24 deletions package/src/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import type {
import { resolveHTTPResponse, type ResponseMeta } from '@trpc/server/http';
import type { TRPCResponse } from '@trpc/server/rpc';
import type { ValidRoute } from './ValidRoute';
import { serialize, type CookieSerializeOptions } from 'cookie';

/**
* Create a SvelteKit handle function for tRPC requests.
Expand Down Expand Up @@ -85,14 +86,33 @@ export function createTRPCHandle<Router extends AnyRouter, URL extends string>({
// as the event in not resolved by SvelteKit. Instead, we "proxy" the access
// to the headers.
const originalSetHeaders = event.setHeaders;
const originalSetCookies = event.cookies.set;
const originalDeleteCookies = event.cookies.delete;
const headersProxy: Record<string, string> = {};
const cookiesProxy: Record<string, { value: string; options: CookieSerializeOptions }> = {};

// Same as the one provided from sveltekit
const defaultCookiesOptions: CookieSerializeOptions = {
httpOnly: true,
sameSite: 'lax',
secure: event.url.hostname === 'localhost' && event.url.protocol === 'http:' ? false : true
};

event.setHeaders = (headers) => {
for (const [key, value] of Object.entries(headers)) {
headersProxy[key] = value;
}
// Still call the original `event.setHeaders` function, as it may be used in SvelteKit internals.
originalSetHeaders(headers);
};
event.cookies.set = (name, value, options) => {
cookiesProxy[name] = { value, options: { ...defaultCookiesOptions, ...options } };
originalSetCookies(name, value, options);
};
event.cookies.delete = (name, options) => {
cookiesProxy[name] = { value: '', options: { ...options, maxAge: 0 } };
originalDeleteCookies(name, options);
};

const httpResponse = await resolveHTTPResponse({
router,
Expand All @@ -110,35 +130,17 @@ export function createTRPCHandle<Router extends AnyRouter, URL extends string>({
body: string;
};

// Set headers and cookies that were set using SvelteKit's `event.setHeaders` and `event.cookies.set`.
for (const [key, value] of Object.entries(headersProxy)) {
headers[key] = value;
}
// Current cookies from TRPC
const currentCookiesHeaders =
headers['Set-Cookie']?.split('; ').map((cookie) => {
const name = cookie.split('=')[0];
const value = cookie.split('=').at(1);
return { name, value };
}) ?? [];
// Add / Replace cookies from SvelteKit
for (const cookie of event.cookies.getAll()) {
// Remove existing cookie
const existingCookieIndex = currentCookiesHeaders.findIndex((c) => c.name === cookie.name);
if (existingCookieIndex !== -1) {
currentCookiesHeaders.splice(existingCookieIndex, 1);
}

// Add the new cookie
currentCookiesHeaders.push({
name: cookie.name,
value: cookie.value
});
if (Object.keys(cookiesProxy).length > 0) {
let cookieHeader = headers['Set-Cookie'] ?? '';
for (const [name, { value, options }] of Object.entries(cookiesProxy)) {
cookieHeader += serialize(name, value, options) + '; ';
}
headers['Set-Cookie'] = cookieHeader;
}
// Set "Set-Cookie" header
headers['Set-Cookie'] = currentCookiesHeaders
.map((cookie) => `${cookie.name}=${cookie.value}`)
.join('; ');

return new Response(body, { status, headers });
}
Expand Down