Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Width & Height scale to the pictures #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moattarwork
Copy link
Contributor

@moattarwork moattarwork commented Jun 17, 2021

Pull Request Template

Description

The PR includes adding scaling capability to the image by either height or width.

New Features

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Dependent Releases

Nothing

Required Configuration on CI/CD platform

Nothing

How Has This Been Tested?

It's been tested through unit testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • My changes fulfill the acceptance criteria for the story or bug
  • I made/planned the required configuration changes on CI/CD

Copy link

@LewisPercival LewisPercival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one Mo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants