-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for docker #49
Conversation
process/score_upload.nf
Outdated
containerOptions "--bind \$(pwd):/score-client/logs" | ||
containerOptions "--bind \$(pwd):/song-client/logs" | ||
} else if (workflow.containerEngine == "docker") { | ||
containerOptions "-v \$(pwd):/song-client/logs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be score-client/logs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in
nextflow-data-processing-utility-tools/process/score_upload.nf
Lines 37 to 40 in 1a01b2e
if (workflow.containerEngine == "singularity") { | |
containerOptions "--bind \$(pwd):/score-client/logs" | |
} else if (workflow.containerEngine == "docker") { | |
containerOptions "-v \$(pwd):/score-client/logs" |
@@ -36,6 +36,8 @@ process scoreUpload { | |||
|
|||
if (workflow.containerEngine == "singularity") { | |||
containerOptions "--bind \$(pwd):/score-client/logs" | |||
} else if (workflow.containerEngine == "docker") { | |||
containerOptions "-v \$(pwd):/score-client/logs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very minor suggestion, can we change to
-v \$(pwd)/logs:/score-client/logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- A very minor suggestion.
- Question: do we plan to make similar changes to
song-score-download
?
closing. new branch in #51 |
No description provided.