Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Candidate 3.1.1 #31

Merged
merged 7 commits into from
Sep 4, 2019
Merged

Release Candidate 3.1.1 #31

merged 7 commits into from
Sep 4, 2019

Conversation

joneubank
Copy link
Member

@joneubank joneubank commented Sep 4, 2019 •
edited
Loading

Functional Changes

  • Updated Ego JWT expected shape to match Ego version 2.7 https://github.com/overture-stack/ego/releases/tag/2.7.0 . Permissions now read from jwt.context.scope instead of jwt.context.user.permissions
  • Ego JWT tokens now require a public key to be verified. If the public key is missing or the token doesnt match isValidJwt will return false, and decodeToken will throw an error. Other checks (such as isDccMember) will return false for a token that fails public key validation

Code Changes

  • Standardized Prettier formatting to match other ARGO repositories
  • move isRole type methods to a argoRoleChecks file (out of common/utils)

@joneubank
✨ Update JWT shape, read scopes from context.scope
e93117d
@joneubank
✅ Update test JWT values to match new EGO shape
86973f7
@joneubank
Merge pull request #26 from icgc-argo/feat/update-for-ego-shape-change
b800e78 
Updates for ego shape change
@joneubank
Standardize Prettier Config (#27)
af13c76 
* ✨ Update JWT shape, read scopes from context.scope

* ✅ Update test JWT values to match new EGO shape

* 🎨 Argo standard prettier config and autoformat all files
@joneubank
Verify JWT against Public Key (#29)
968e2df 
* ✨ jwtDecode does not validate public key

* ✨ Verify jwt vs public key
@joneubank
🔖 Versioning 3.1.1
dda312b
@joneubank
🔖 Switching author to org name
b223513
@andricDu andricDu merged commit b2c09b9 into master Sep 4, 2019
@joneubank joneubank deleted the rc/3.1.1 branch September 4, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andricDu andricDu andricDu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joneubank @andricDu