Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Only Works on Node.js #25

Closed
threeal opened this issue Mar 20, 2021 · 0 comments · Fixed by #26
Closed

Client Only Works on Node.js #25

threeal opened this issue Mar 20, 2021 · 0 comments · Fixed by #26
Assignees
@threeal
Labels
bug Something isn't working
Projects
Kumo
Milestone
First Major Release

Comments

@threeal
Copy link
Member

threeal commented Mar 20, 2021

As in the websocket module's readme, the currently used WebSocketClient class only works on Node.js, and not the browser. Hence, it's better to replace the WebSocketClient class with the W3CWebSocket class that works on the browser.
@threeal threeal self-assigned this Mar 20, 2021
@threeal threeal added the bug Something isn't working label Mar 20, 2021
@threeal threeal added this to To do in Kumo via automation Mar 20, 2021
@threeal threeal added this to the Version 1.0.0 milestone Mar 20, 2021
@threeal threeal mentioned this issue Mar 20, 2021
Merged
Kumo automation moved this from To do to Done Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@threeal threeal

Labels
bug Something isn't working
Projects
Kumo
  
Done
Milestone
First Major Release
Development

Successfully merging a pull request may close this issue.

Replacing WebSocketClient with W3CWebSocket ichiro-its/kumo-client
1 participant
@threeal