Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the Bridge Class #32

Closed
threeal opened this issue Apr 17, 2021 · 0 comments · Fixed by #33
Closed

Modify the Bridge Class #32

threeal opened this issue Apr 17, 2021 · 0 comments · Fixed by #33
Assignees
@threeal
Labels
enhancement New feature or request
Projects
Kumo
Milestone
First Major Release

Comments

@threeal
Copy link
Member

threeal commented Apr 17, 2021

Modify the bridge class as follow:

  • Return a promise on the connect function.
  • Support to set multiple callback on the Bridge object so it could be called as follow: 
    bridge()
  .onConnect(...)
  .onConnect(...)
  .onDisconnect(...);
@threeal threeal added the enhancement New feature or request label Apr 17, 2021
@threeal threeal added this to To do in Kumo via automation Apr 17, 2021
@threeal threeal added this to the Version 1.0.0 milestone Apr 17, 2021
@threeal threeal self-assigned this Apr 17, 2021
@threeal threeal mentioned this issue Apr 17, 2021
Merged
Kumo automation moved this from To do to Done Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@threeal threeal

Labels
enhancement New feature or request
Projects
Kumo
  
Done
Milestone
First Major Release
Development

Successfully merging a pull request may close this issue.

32 modify the bridge class ichiro-its/kumo-client
1 participant
@threeal