Use zero width join character for better rendering in Chrome #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbw20
referenced
this pull request
Nov 30, 2015
And we can type right after the atwho-inserted element fix #262
ichord
added a commit
that referenced
this pull request
Dec 1, 2015
Use zero width join character for better rendering in Chrome
|
@wbw20 Cool. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ichord @chrisfay
This PR switches Editable Controller from using the word joiner character to using the zero width joiner character. The normal word joiner, \u2060, is broken in my version of Chrome (46.0.2490.86, 64 bit) on mac:
Using the zero width joiner seems to accomplish the same things while rendering properly.