New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple issues #21

Closed

wychoong opened this issue Oct 10, 2023 · 1 comment

wychoong commented Oct 10, 2023

hi, thanks for creating this simple OTP package. However, several issues are observed

improper use of Laravel Facade
see issue Non-static method Ichtrojan\\Otp\\Otp::generate() cannot be called statically #11
otp:clean command doesn't take in tokens that is expired but never validated before

looking at how multiple PRs with improvements are closed without any comments, are you open for PR?

The text was updated successfully, but these errors were encountered:

Owner

ichtrojan commented Dec 25, 2023

Hello,

Got rid of Facades but you can send in a PR to fix the OTP clean issue.

ichtrojan closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment