Remove unnecessary onRejected callbacks

icicleio · Jul 8, 2015 · 44a5cbb · 44a5cbb
1 parent 57a58ee
commit 44a5cbb
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 15 deletions.
diff --git a/tests/Connector/ConnectorTest.php b/tests/Connector/ConnectorTest.php
@@ -73,7 +73,7 @@ public function testConnect()
         $callback->method('__invoke')
             ->with($this->isInstanceOf(ClientInterface::class));
 
-        $promise->done($callback, $this->createCallback(0));
+        $promise->done($callback);
 
         Loop\run();
     }
@@ -115,7 +115,6 @@ public function testResolveEmpty()
         $port = 443;
         $timeout = 0.1;
         $retries = 2;
-        $ips = ['127.0.0.1'];
         $options = ['timeout' => 0.1, 'name' => '*.example.com'];
 
         $this->resolver->shouldReceive('resolve')
@@ -139,7 +138,6 @@ public function testResolveFailure()
         $port = 443;
         $timeout = 0.1;
         $retries = 2;
-        $ips = ['127.0.0.1'];
         $options = ['timeout' => 0.1, 'name' => '*.example.com'];
 
         $this->resolver->shouldReceive('resolve')
@@ -187,7 +185,7 @@ public function testConnectWithMultipleIPs()
         $callback->method('__invoke')
             ->with($this->isInstanceOf(ClientInterface::class));
 
-        $promise->done($callback, $this->createCallback(0));
+        $promise->done($callback);
 
         Loop\run();
     }
@@ -210,7 +208,7 @@ public function testDomainUsedAsDefaultName()
 
         $promise = new Coroutine($this->connector->connect($domain, $port));
 
-        $promise->done($this->createCallback(1), $this->createCallback(0));
+        $promise->done($this->createCallback(1));
 
         Loop\run();
     }
@@ -248,7 +246,7 @@ public function testConnectWithIPv4Address($ip)
         $callback->method('__invoke')
             ->with($this->isInstanceOf(ClientInterface::class));
 
-        $promise->done($callback, $this->createCallback(0));
+        $promise->done($callback);
 
         Loop\run();
     }
@@ -286,7 +284,7 @@ public function testConnectWithIPv6Address($ip)
         $callback->method('__invoke')
             ->with($this->isInstanceOf(ClientInterface::class));
 
-        $promise->done($callback, $this->createCallback(0));
+        $promise->done($callback);
 
         Loop\run();
     }

diff --git a/tests/Executor/ExecutorTest.php b/tests/Executor/ExecutorTest.php
@@ -161,7 +161,7 @@ public function execute($type, $domain, $request, $response, array $answers = nu
             }
         };
 
-        $coroutine->done($callback, $this->createCallback(0));
+        $coroutine->done($callback);
 
         Loop\run();
     }

diff --git a/tests/Executor/MultiExecutorTest.php b/tests/Executor/MultiExecutorTest.php
@@ -63,7 +63,7 @@ public function execute($type, $domain, $request, $response, array $answers = nu
         $callback->method('__invoke')
             ->with($this->identicalTo($message));
 
-        $coroutine->done($callback, $this->createCallback(0));
+        $coroutine->done($callback);
 
         Loop\run();
     }
@@ -116,7 +116,7 @@ public function testRetriesAfterThrownMessageException()
         $callback->method('__invoke')
             ->with($this->isInstanceOf(Message::class));
 
-        $coroutine->done($callback, $this->createCallback(0));
+        $coroutine->done($callback);
 
         Loop\run();
     }
@@ -145,7 +145,7 @@ public function testNextRequestUsesLastRespondingExecutor()
         $callback->method('__invoke')
             ->with($this->isInstanceOf(Message::class));
 
-        $coroutine->done($callback, $this->createCallback(0));
+        $coroutine->done($callback);
 
         Loop\run(); // Should shift first executor to back of list.
 
@@ -155,7 +155,7 @@ public function testNextRequestUsesLastRespondingExecutor()
         $callback->method('__invoke')
             ->with($this->isInstanceOf(Message::class));
 
-        $coroutine->done($callback, $this->createCallback(0));
+        $coroutine->done($callback);
 
         Loop\run(); // Should call second executor first.
     }

diff --git a/tests/Resolver/ResolverTest.php b/tests/Resolver/ResolverTest.php
@@ -60,7 +60,7 @@ public function testResolve($domain, $request, $response, array $answers = null,
         $callback->method('__invoke')
             ->with($this->equalTo($result));
 
-        $coroutine->done($callback, $this->createCallback(0));
+        $coroutine->done($callback);
 
         Loop\run();
     }
@@ -81,7 +81,7 @@ public function testNotFound()
         $callback->method('__invoke')
             ->with($this->identicalTo([]));
 
-        $coroutine->done($callback, $this->createCallback(0));
+        $coroutine->done($callback);
 
         Loop\run();
     }
@@ -97,7 +97,7 @@ public function testLocalhost()
         $callback->method('__invoke')
             ->with($this->equalTo(['127.0.0.1']));
 
-        $coroutine->done($callback, $this->createCallback(0));
+        $coroutine->done($callback);
 
         Loop\run();
     }