Add ref/unref to sockets

icicleio · Sep 15, 2015 · c88aeeb · c88aeeb
1 parent 63f4f2e
commit c88aeeb
Showing 1 changed file with 28 additions and 3 deletions.
diff --git a/src/Loop/Manager/Uv/SocketManager.php b/src/Loop/Manager/Uv/SocketManager.php
@@ -49,6 +49,11 @@ class SocketManager implements SocketManagerInterface
      */
     private $sockets = [];
 
+    /**
+     * @var \Icicle\Loop\Events\SocketEventInterface[]
+     */
+    private $unreferenced = [];
+
     /**
      * @var callable Callback for poll events.
      */
@@ -133,8 +138,8 @@ public function __destruct()
      */
     public function isEmpty(): bool
     {
-        foreach ($this->polls as $poll) {
-            if (\uv_is_active($poll)) {
+        foreach ($this->polls as $id =>$poll) {
+            if (\uv_is_active($poll) && !isset($this->unreferenced[$id])) {
                 return false;
             }
         }
@@ -231,7 +236,7 @@ public function free(SocketEventInterface $socket)
         $id = (int) $socket->getResource();
 
         if (isset($this->sockets[$id]) && $socket === $this->sockets[$id]) {
-            unset($this->sockets[$id]);
+            unset($this->sockets[$id], $this->unreferenced[$id]);
 
             if (isset($this->polls[$id])) {
                 \uv_close($this->polls[$id]);
@@ -258,6 +263,26 @@ public function isFreed(SocketEventInterface $socket): bool
         return !isset($this->sockets[$id]) || $socket !== $this->sockets[$id];
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function reference(SocketEventInterface $socket)
+    {
+        unset($this->unreferenced[(int) $socket->getResource()]);
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function unreference(SocketEventInterface $socket)
+    {
+        $id = (int) $socket->getResource();
+
+        if (isset($this->sockets[$id]) && $socket === $this->sockets[$id]) {
+            $this->unreferenced[$id] = $socket;
+        }
+    }
+
     /**
      * {@inheritdoc}
      */