perf_event: initial heterogeneous CPU support #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagode
approved these changes
Jun 27, 2024
this should not change the behavior of the code, just adding some comments and whitespace to clear up what the code is actually doing to prepare for improved heterogeneous CPU support
Alderlake and Raptorlake should now be able to properly enumerate events for both Power and Efficiency cores on heterogeneous systems. We're still testing if PAPI properly handles measurements where applications end up running on both types of cores. The detection of E-cores is currently a bit of a hack, we're going to discuss with upstream libpfm4 to see if we can get a cleaner interface for this.
…inition this shouldn't be possible with a correctly configured papi_event.csv but it is still good to be robust here so that we don't segfault and also print useful debug messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for Intel alderlake and raptorlake heterogeneous CPUs that have both e-cores and p-cores. This makes it so PAPI can build, run, and enumerate native events on these systems. (Without these patches PAPI won't run at all, it will just give an error).
We are still working on validating the results gathered by PAPI on these systems.