2023.06.20 fix fortran test flags #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcongiu
force-pushed
the
2023.06.20_fix-fortran-test-flags
branch
from
f7ce43d
to
d2142ae
Compare
adanalis
approved these changes
Jun 20, 2023
gcongiu
force-pushed
the
2023.06.20_fix-fortran-test-flags
branch
from
d2142ae
to
171cd95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #24. The problem comes from erroneous flags in the test Makefile of the sysdetect and sde components for fortran compilers that are neither gfortran nor flang. More specifically, a Cray fortran compiler build error was reported by the spack project in PR spack/spack#38443. This PR fixes the typo in both
components.
Author Checklist
Why this PR exists. Reference all relevant information including background, issues, test failures, etc
Commits are self contained and only do one thing
The PR needs to pass all the tests