Skip to content

Commit

Permalink
Add a warning of the use of non-single-threaded thread pools
Browse files Browse the repository at this point in the history
  • Loading branch information
iconara committed Apr 29, 2016
1 parent 357ccf1 commit 651f86b
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion lib/ione/io/io_reactor.rb
Expand Up @@ -25,11 +25,16 @@ module Io
# reactor. A thread pool is any object that responds to `#submit`, takes a
# block and returns a future which resolves to the value of calling the
# block. It's completely up to the implementation when and how the block is
# called. The default implementation, simply calls the block immediately.
# called. The default implementation simply calls the block immediately.
#
# The callbacks that are called in the thread pool are `Connection#on_data`,
# `ServerConnection#on_data` ({BaseConnection#on_data}) and
# {Acceptor#on_accept}.
#
# If you provide a thread pool with more than one thread multiple chunks
# from the same connection can be processed in parallel, and it's up to you
# to serialize the processing per connection.
#
# The IO reactor is completely protocol agnostic, and it's up to you to
# create objects that can interpret the bytes received from remote hosts,
# and to send the correct commands back. The way this works is that when you
Expand Down

0 comments on commit 651f86b

Please sign in to comment.