refactor: drop @types/cheerio

[yunsii]

#35

[yunsii]

Export default cheerio instance is deprecated, ref: https://github.com/cheeriojs/cheerio/blob/v1.0.0-rc.12/src/index.ts#L64

So importing * as cheerio instead of this default export, ref: https://github.com/cheeriojs/cheerio/blob/a13961b99f11fd260e6594f995ad86759347eddb/src/index.ts#L70 (newest code for now)

[cyberalien]

Tested, it fails to compile pretty much on every change.

Are you not getting any errors when trying to build it?

[cyberalien]

Doesn't work, throws error.

[cyberalien]

Why? And it doesn't work.

[yunsii]

I only run build and test of @iconify/tools, I will process it right now.

[yunsii]

@cyberalien It's wired, why encounter these errors?

[cyberalien]

I only run build and test of @iconify/tools, I will process it right now.

Yes, I'm running that too, other packages don't really matter. It doesn't work for me.

@cyberalien It's wired, why encounter these errors?

This means dependencies weren't installed. Re-run pnpm install (or ni if you are using @antfu/ni package).

[cyberalien]

I only run build and test of @iconify/tools, I will process it right now.

Yes, I'm running that too, other packages don't really matter. It doesn't work for me.

I'm getting errors when parsing types on every changed file.

[yunsii]

I'm getting errors when parsing types on every changed file.

What's the meaning? Here is my result:

Build passed, test encounters download errors only.

[cyberalien]

Strange. Do you get errors when running lint command?

[yunsii]

Strange. Do you get errors when running lint command?

It seems alse not.

[cyberalien]

This is what I get with build, with lint and you can also see a warning in editor

[cyberalien]

This is a very weird situation, not sure which dev environment is bugged: maybe yours, maybe mine. So currently running ci to test on separate environment.

[cyberalien]

So ci run was a success, which means bug is in my environment. Very very weird.

Doh. Sorry.

[yunsii]

I think you can use a online IDE to test, it works in my personal and company computer.

[cyberalien]

Got it to work!

It appears pnpm left @types/cheerio in modules, even though packages no longer have it.

Doing some tests now...

[cyberalien]

Works perfectly

[cyberalien]

Thanks a lot and sorry for mess.

Merged. I've also removed duplicate entries, so types are now in one file.

[cyberalien]

Published with next tag.

For now it won't be added to stable because:

• This is likely a breaking change, so at least new minor version is needed, not patch.
• I've ran into unrelated issue when working with large icons, which will more likely require another breaking change to fix, but that one will be a major change.

So this is a possibly breaking change and I will likely add another breaking change soon, so I'd rather have one new major version with all those changes instead of publishing temporary version.

[yunsii]

Sure, @types/cheerio's types declare in global namespace 😂