Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IsOption into the back ends #115

Closed
cdornan opened this issue Apr 4, 2017 · 0 comments · Fixed by #121
Closed

Move IsOption into the back ends #115

cdornan opened this issue Apr 4, 2017 · 0 comments · Fixed by #121
Assignees
@cdornan
Labels
in progress
Milestone
v0.14.0.0

Comments

@cdornan
Copy link
Contributor

cdornan commented Apr 4, 2017

It is always mighty tempting to avoid duplication, but having a single a single IsOption class in ReOptions makes for a needlessly complicated multi-parameter type class, parameterised over the RE type and the back-end compiler and execution options. Far better to have a single class in each of the back-end modules (Text.RE.ZeInternals.{TDFA,PCRE}).
@cdornan cdornan added this to the v0.14.0.0 milestone Apr 4, 2017
@cdornan cdornan self-assigned this Apr 4, 2017
cdornan added a commit that referenced this issue Apr 5, 2017
@cdornan
0.14.0.0: Move IsOption, rename Find functions
8910e2e 
  * Move IsOption into the back ends (fixes #115)
  * Rename Find functions (fixes #116)
  * re-gen-cabals: 'sdist' to prepare final commit message (fixes #117)
  * re-prep: 'blog-badge' to update the blog badge (fixes #118)
  * re-prep: include_code_pp for all .lhs files (fixes #119)
  * re-gen-cabals: do 'gen' after 'bump-version' (fixes #120)
@cdornan cdornan mentioned this issue Apr 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdornan cdornan

Labels
in progress
Projects
None yet
Milestone
v0.14.0.0
Development

Successfully merging a pull request may close this issue.

0.14.0.0: Move IsOption, rename Find functions iconnect/regex
1 participant
@cdornan