Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IsOption into the back ends #115

Closed
cdornan opened this issue Apr 4, 2017 · 0 comments
Closed

Move IsOption into the back ends #115

cdornan opened this issue Apr 4, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@cdornan
Copy link
Contributor

@cdornan cdornan commented Apr 4, 2017

It is always mighty tempting to avoid duplication, but having a single a single IsOption class in ReOptions makes for a needlessly complicated multi-parameter type class, parameterised over the RE type and the back-end compiler and execution options. Far better to have a single class in each of the back-end modules (Text.RE.ZeInternals.{TDFA,PCRE}).

@cdornan cdornan added the in progress label Apr 4, 2017
@cdornan cdornan added this to the v0.14.0.0 milestone Apr 4, 2017
@cdornan cdornan self-assigned this Apr 4, 2017
cdornan added a commit that referenced this issue Apr 5, 2017
  * Move IsOption into the back ends (fixes #115)
  * Rename Find functions (fixes #116)
  * re-gen-cabals: 'sdist' to prepare final commit message (fixes #117)
  * re-prep: 'blog-badge' to update the blog badge (fixes #118)
  * re-prep: include_code_pp for all .lhs files (fixes #119)
  * re-gen-cabals: do 'gen' after 'bump-version' (fixes #120)
@cdornan cdornan closed this in #121 Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant