Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Oculus Mixed Reality Capture Camera pose #80

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

fabio914
Copy link

@fabio914 fabio914 commented Apr 2, 2021

Changes

This is an attempt to solve #44 without modifying the Oculus Integration Package.

  • This PR fixes the issues with the Oculus Mixed Reality camera positions because of the different units used by Open Brush (decimeters instead of meters).

This PR is similar to #70, however, it doesn't have the changes for Reality Mixer.

cc @mikeage @mikeskydev

Copy link
Contributor

@TimAidley TimAidley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to see this one in! I had a minor nit about line length.

Assets/Scripts/MRCCameraUpdate.cs Outdated Show resolved Hide resolved
@mikeskydev
Copy link
Member

Good idea to split them off, thanks! Will give this a test tonight and get it in.

@mikeskydev
Copy link
Member

Gave this a shot with my webcam but was struggling to get a proper calibration going, will try tomorrow morning on our full MR setup. However, I did notice that the world camera capture seemed to move when I titled my head side to side, which probably shouldn't be happening with MR?

@fabio914
Copy link
Author

fabio914 commented Apr 3, 2021

but was struggling to get a proper calibration going

The Oculus MRC Calibration app is freezing for me from time to time when I try to calibrate. Were you experiencing something similar? This started happening for me after my Quest started using version 27 of the system.

However, I did notice that the world camera capture seemed to move when I tilted my head side to side, which probably shouldn't be happening with MR?

I tested again here, and I also noticed some movement, although it's very hard to notice (see the video below). My guess is that this happens because this update with the fix is out of sync with the MRC update (probably 1 or more frames apart), so the matrix for the head position that we're using here doesn't match exactly the one being used when the MRC camera position is being computed.

output.mp4

Copy link
Member

@mikeskydev mikeskydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it working great, just needed a better calibration! Thanks for sorting this!

@mikeskydev mikeskydev merged commit 4c5670f into icosa-foundation:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants