Run dotnet format on the entire codebase (and enforce, going forward) #81
+125,416
−105,294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as draft since we don't want to merge this while we have open PRs |
mikeage
force-pushed
the
dotnet-format
branch
3 times, most recently
from
a028817
to
d3d34c8
Compare
billyquith
reviewed
Apr 15, 2021
| @@ -7,3 +7,6 @@ root = true | |||
| indent_style = space | |||
| indent_size = 2 | |||
|
|
|||
| # Based on Google's C# style guide | |||
There was a problem hiding this comment.
4 space indents will make this comment no longer true!
There was a problem hiding this comment.
Good point, this is from an earlier version where I tried to mimic the original style
There are a few small places where rider/resharper and dotnet-format disagree; in this case, dotnet-format is the definitive version.
This was referenced Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
dotnet-formatto the checkers run by pre-commit.By running
pip install pre-commit && pre-commit installin your clone (python3 required), it will automatically run any newly modified files throughdotnet-format. Additionally, as the style rules are in.editorconfig, they should be respected by most editors.Once this is merged, the commit can be added to a .git-blame-ignore-revs file so that
git blamefrom the command line will skip any changes made as part of this PR. See, for example, https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame for more information