Update README & BuildTiltBrush.cs for beginners #124
Conversation
Assets/Editor/BuildTiltBrush.cs
Outdated
| @@ -1218,6 +1218,7 @@ public static void DoBuild(TiltBuildOptions tiltOptions) | |||
| string stamp = tiltOptions.Stamp; | |||
| SdkMode vrSdk = tiltOptions.VrSdk; | |||
| BuildOptions options = tiltOptions.UnityOptions; | |||
| // Add your new scenes in this List for your app for Oculus Quest | |||
There was a problem hiding this comment.
You should delete the 'for Oculus Quest' here as the same applies to PC builds as well.
Also, [optional] it might be better to rephrase this as something like:
// During the build process the Scene List in the Build Settings is ignored.
// Only the following scenes are included in the build.
... as that describes what the code does, rather than what the reader should do.
There was a problem hiding this comment.
I really appreciate your reaction !!
I changed the notes with your idea.
I'm so excited with the chance to contribute this great project !!
README.md
Outdated
| @@ -255,6 +255,8 @@ Follow these steps to build your app for Oculus Quest: | |||
| `../Builds/OculusMobile_Release_OpenBrush_FromGui/`. | |||
| 1. Run `adb install com.Icosa.OpenBrush.apk`. | |||
|
|
|||
| **Note:** Add your new scene files' names in List '`scene`' on 1221st line in `../Assets/Editor/BuildTiltBrush.cs` before building. If you didn't, your app won't be built with those scenes even if they are put on `Scenes In Build` in `Build Settings`. | |||
There was a problem hiding this comment.
I would avoid mentioning specific line numbers as it's unlikely people will remember to update that if they make changes. Maybe say something like "... add to the list defined in the DoBuild method ( string[] scenes = {...} )"
|
@andybak I revised |
This PR is for building own app with other scenes added for beginners.
Changes
README- Add explanation about 'the way to build with new scenes added for beginner developers' inBuilding your app for Oculus Queststep.BuildTiltBrush.cs- Add explanation about 'the way to build with new scenes added for beginner developers' on 1221st line.I'm a student making a project with
Open Brushas an Open Brush sample project.While making a new project, one of the most difficult things to solve was finding a way to add my new scenes in this project.
In the case of building in the way README file is letting people know,
Tilt > Build > Do Build, new scenes are never added before changeBuildTiltBrush.csbut this document isn't explaining this problem, and this is very difficult to solve for beginners.This project and document are awesome, but I think the document should be more beginner friendly.
I really like this project and I hope the sample project I will make to be able to contributes to this project. At the same time, I hope many novice developers can use this project to create many new projects with the revised document. Thank you !