Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for sub-class snippets through the website #48

Closed
GrahamTheCoder opened this issue Mar 15, 2018 · 0 comments
Closed

Improve support for sub-class snippets through the website #48

GrahamTheCoder opened this issue Mar 15, 2018 · 0 comments
Assignees

Comments

@GrahamTheCoder
Copy link
Member

GrahamTheCoder commented Mar 15, 2018

Converting just a method will appear to work, but in fact it's missing all symbol information and hence will make lots of wrong guesses about the conversion.

Currently there's a hack which catches total conversion failures and tries again with a method/class surrounding the code. The proper solution is to detect up front when we have a partial snippet, and surround it in a method and/or class as appropriate.

See example of code that doesn't work without context at #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant