Disabled out name filter for create field,property and method.

icsharpcode · Mar 27, 2012 · 62ebfc7 · 62ebfc7
1 parent b1dfdba
commit 62ebfc7
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 28 deletions.
diff --git a/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/CreateFieldAction.cs b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/CreateFieldAction.cs
@@ -66,10 +66,10 @@ public IEnumerable<CodeAction> GetActions(RefactoringContext context)
 			var state = context.GetResolverStateBefore(identifier);
 			bool isStatic = state.CurrentMember.IsStatic;
 
-			var service = (NamingConventionService)context.GetService(typeof(NamingConventionService));
-			if (service != null && !service.IsValidName(identifier.Identifier, AffectedEntity.Field, Modifiers.Private, isStatic)) { 
-				yield break;
-			}
+//			var service = (NamingConventionService)context.GetService(typeof(NamingConventionService));
+//			if (service != null && !service.IsValidName(identifier.Identifier, AffectedEntity.Field, Modifiers.Private, isStatic)) { 
+//				yield break;
+//			}
 
 			yield return new CodeAction(context.TranslateString("Create field"), script => {
 				var decl = new FieldDeclaration() {

diff --git a/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/CreateMethodDeclarationAction.cs b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/CreateMethodDeclarationAction.cs
@@ -132,10 +132,10 @@ public IEnumerable<CodeAction> GetActionsFromInvocation(RefactoringContext conte
 				isStatic = invocation.Target is IdentifierExpression && state.CurrentMember.IsStatic;
 			}
 
-			var service = (NamingConventionService)context.GetService(typeof(NamingConventionService));
-			if (service != null && !service.IsValidName(methodName, AffectedEntity.Method, Modifiers.Private, isStatic)) { 
-				yield break;
-			}
+//			var service = (NamingConventionService)context.GetService(typeof(NamingConventionService));
+//			if (service != null && !service.IsValidName(methodName, AffectedEntity.Method, Modifiers.Private, isStatic)) { 
+//				yield break;
+//			}
 
 			yield return new CodeAction(context.TranslateString("Create method"), script => {
 				var decl = new MethodDeclaration() {

diff --git a/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/CreatePropertyAction.cs b/ICSharpCode.NRefactory.CSharp/Refactoring/CodeActions/CreatePropertyAction.cs
@@ -83,10 +83,10 @@ public IEnumerable<CodeAction> GetActions(RefactoringContext context)
 				isStatic = identifier is IdentifierExpression && state.CurrentMember.IsStatic;
 			}
 
-			var service = (NamingConventionService)context.GetService(typeof(NamingConventionService));
-			if (service != null && !service.IsValidName(propertyName, AffectedEntity.Property, Modifiers.Private, isStatic)) { 
-				yield break;
-			}
+//			var service = (NamingConventionService)context.GetService(typeof(NamingConventionService));
+//			if (service != null && !service.IsValidName(propertyName, AffectedEntity.Property, Modifiers.Private, isStatic)) { 
+//				yield break;
+//			}
 
 			yield return new CodeAction(context.TranslateString("Create property"), script => {
 				var decl = new PropertyDeclaration() {

diff --git a/ICSharpCode.NRefactory.Tests/CSharp/CodeActions/CreateFieldTests.cs b/ICSharpCode.NRefactory.Tests/CSharp/CodeActions/CreateFieldTests.cs
@@ -32,22 +32,7 @@ namespace ICSharpCode.NRefactory.CSharp.CodeActions
 	[TestFixture]
 	public class CreateFieldTests : ContextActionTestBase
 	{
-		[Test()]
-		public void TestWrongContext1 ()
-		{
-			TestWrongContext<CreateFieldAction> (
-				"using System;" + Environment.NewLine +
-					"class TestClass" + Environment.NewLine +
-					"{" + Environment.NewLine +
-					"	void Test ()" + Environment.NewLine +
-					"	{" + Environment.NewLine +
-					"		Console.WriteLine ($Foo);" + Environment.NewLine +
-					"	}" + Environment.NewLine +
-					"}"
-			);
-		}
-
-		[Test()]
+	[Test()]
 		public void TestWrongContext2 ()
 		{
 			TestWrongContext<CreateFieldAction> (