Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ZipOutputStream.CloseEntry() to work for AES encrypted Stored entries #323

Merged
merged 2 commits into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@Numpsy
Copy link
Contributor

Numpsy commented Feb 18, 2019

Possible fix for #322 - Change ZipOutputStream.CloseEntry() to set up AESAuthCode itself when the compression method is 'Stored' (it's normally done by DeflatorOutputStream.Finish(), which isn't called in this case).

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@piksel

This comment has been minimized.

Copy link
Collaborator

piksel commented Feb 18, 2019

This seems like an OK solution. The authcode should probably not be handled by Deflate in the first place, but rather in another layer. But that would be a much larger restructure.

@piksel piksel merged commit afcccb0 into icsharpcode:master Mar 4, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Numpsy Numpsy deleted the Numpsy:zip_aes_store branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.