Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some basic async unit tests for the inflator/deflator streams #457

Merged
merged 3 commits into from Feb 6, 2021

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Apr 26, 2020

refs #223

Basically just adds async versions of the 'InflateDeflateZlib' and 'InflateDeflateNonZlib' tests and shuffles some things about to share some of the test code instead of duplicating it all.

Also changes the tests to use the NUnit 'Range' attribute for testing the different compression levels instead of having one test that loops over all the levels internally (makes the test a bit simpler, also makes each level appear as a seperate test in the results)

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@Numpsy Numpsy added the tests label May 3, 2020
@piksel piksel self-requested a review May 27, 2020 21:36
@Numpsy
Copy link
Contributor Author

Numpsy commented May 28, 2020

Also changes the tests to use the NUnit 'Range' attribute for testing the different compression levels instead of having one test that loops over all the levels internally (makes the test a bit simpler, also makes each level appear as a seperate test in the results)

Could break that bit out into a separate PR to minimize the diff on the actual async bits if that's helpful.

@Numpsy
Copy link
Contributor Author

Numpsy commented Aug 4, 2020

I put the simple not-actually-async-related changes in #494 in case that makes it easier to review (could just close that one if not)

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was really hard to CR since it moved code in several places (and added new which was similar). I Tried to move around it a bit to get a better diff, but it's still a mess.
AFAICT it looks good though, it's just adding async versions of test helpers and moving shared sections to separate helpers.

@piksel piksel merged commit 1193672 into icsharpcode:master Feb 6, 2021
@Numpsy Numpsy deleted the rw/async/InflateDeflateAsync branch February 11, 2021 22:46
@Numpsy
Copy link
Contributor Author

Numpsy commented Feb 11, 2021

Yes, there is perhaps a lot of scope for tidying some of these things up. (we might hit similar situations when/if adding async variants of the other existing tests later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants