ci: use server 2019 for win builds #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
=======================================
Coverage 73.82% 73.82%
=======================================
Files 68 68
Lines 8353 8353
=======================================
Hits 6167 6167
Misses 2186 2186 Continue to review full report at Codecov.
|
piksel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
windows-latesttag was changed fromwindows-2019towindows-2022(ref github/docs#15603).Unfortunately, that means it does no longer contain any runtime/targeting pack for deprecated .NET frameworks (
net45in our case). This changes the CI to instead target the latest working version (windows-2019).Perhaps a supported runtime scope update is due, but that's another discussion.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.