Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace uses of obsolete method RNGCryptoServiceProvider #766

Merged

Conversation

yihezkel
Copy link
Contributor

Replace insecure obsolete method (new RNGCryptoServiceProvider()) with RandomNumberGenerator.Create() in PkzipClassic, ZipFile and ZipOutputStream.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

…h RandomNumberGenerator.Create() in PkzipClassic, ZipFile and ZipOutputStream.
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #766 (8a9dcb9) into master (b5b1b07) will increase coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
+ Coverage   74.10%   74.13%   +0.02%     
==========================================
  Files          71       71              
  Lines        8441     8450       +9     
==========================================
+ Hits         6255     6264       +9     
  Misses       2186     2186              
Impacted Files Coverage Δ
...ICSharpCode.SharpZipLib/Encryption/PkzipClassic.cs 71.02% <0.00%> (ø)
src/ICSharpCode.SharpZipLib/Zip/ZipFile.cs 77.24% <100.00%> (ø)
src/ICSharpCode.SharpZipLib/Zip/ZipOutputStream.cs 87.82% <100.00%> (ø)
...harpCode.SharpZipLib/Encryption/ZipAESTransform.cs 89.09% <0.00%> (ø)
...arpCode.SharpZipLib/Tar/TarExtendedHeaderReader.cs 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I actually did this in the v1.4 branch, but this is more explicit and thorough. Thanks!

@piksel piksel changed the title Replace insecure obsolete method new RNGCryptoServiceProvider() fix: replace uses of obsolete method RNGCryptoServiceProvider Aug 16, 2022
@piksel piksel merged commit 79614c5 into icsharpcode:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants