Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix severe perf degradation reading Stored file in Mono #85

Merged
merged 1 commit into from
May 9, 2016

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2015

When reading a stored file, ZipFile returns a PartialInputStream
directly instead of wrapping it with a decompression layer.

PartialInputStream handles sharing the underlying stream among
multiple threads by calling Seek() before each read.

Unlike Microsoft's reference implementation, Mono's FileStream
flushes its internal read buffer on every Seek.

When reading a stored file, ZipFile returns a PartialInputStream
directly instead of wrapping it with a decompression layer.

PartialInputStream handles sharing the underlying stream among
multiple threads by calling Seek() before each read.

Unlike Microsoft's reference implementation, Mono's FileStream
flushes its internal read buffer on every Seek.
@McNeight McNeight added the enhancement Feature request or other improvements of existing functionality label Apr 14, 2016
@McNeight McNeight self-assigned this Apr 14, 2016
@McNeight McNeight mentioned this pull request Apr 14, 2016
@McNeight McNeight added zip Related to ZIP file format xplat Cross Platform, related to running SharpZipLib in non-windows environments labels Apr 15, 2016
@McNeight McNeight merged commit b3d0e14 into icsharpcode:master May 9, 2016
@McNeight
Copy link
Contributor

McNeight commented May 9, 2016

Paul,

Thanks for responding, and thank you for your contribution.

-Neil

@McNeight McNeight modified the milestone: 1.0 May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or other improvements of existing functionality xplat Cross Platform, related to running SharpZipLib in non-windows environments zip Related to ZIP file format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants