Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code enhancements and bug fix for geoid #109

Merged
merged 6 commits into from
May 1, 2021

Conversation

rogerfraser
Copy link
Member

This pull request adds several code enhancements to geoid in the context of working with NTv2 geoid grid files, and addresses a defect relating to reading ASCII NTv2 geoid grid files on Linux, namely the handling of new line characters. On Windows, a new line is represented by a carriage return (CR) and a line feed (LF) as "\r\n", whereas on Unix and Unix-like systems (e.g. Linux, Mac OS, BSD, etc.), a new line is represented by a line feed (LF) only ("\n")

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #109 (4ebaba7) into master (2cfdde2) will increase coverage by 0.16%.
The diff coverage is 80.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   71.11%   71.28%   +0.16%     
==========================================
  Files         117      117              
  Lines       34224    34270      +46     
==========================================
+ Hits        24339    24429      +90     
+ Misses       9885     9841      -44     
Impacted Files Coverage Δ
dynadjust/dynadjust/dnageoid/dnageoid.hpp 100.00% <ø> (ø)
dynadjust/dynadjust/dnageoid/dnageoid_ext.hpp 100.00% <ø> (ø)
dynadjust/include/config/dnaoptions.hpp 29.23% <ø> (ø)
dynadjust/dynadjust/dnageoid/dnageoid.cpp 68.55% <77.34%> (+1.23%) ⬆️
...just/dynadjust/dnageoidwrapper/dnageoidwrapper.cpp 79.75% <90.32%> (-0.18%) ⬇️
...st/dynadjust/dnaadjustwrapper/dnaadjustwrapper.cpp 87.43% <100.00%> (+1.28%) ⬆️
dynadjust/include/functions/dnaiostreamfuncs.hpp 66.66% <100.00%> (+1.96%) ⬆️
dynadjust/dynadjust/dnaadjust/dnaadjust.cpp 86.85% <0.00%> (+0.35%) ⬆️
...t/dynadjust/dnaadjustwrapper/dnaadjustprogress.cpp 61.32% <0.00%> (+0.55%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cfdde2...4ebaba7. Read the comment docs.

@rogerfraser rogerfraser merged commit ef25f70 into icsm-au:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants