-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.2.4 (WGS 84 support) #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.2.4 release candidate 1
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
- Coverage 82.38% 82.10% -0.28%
==========================================
Files 117 118 +1
Lines 32531 32961 +430
==========================================
+ Hits 26800 27064 +264
- Misses 5731 5897 +166
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces several enhancements to import and reftran to support handling of the World Geodetic System 1984 (WGS 84) and thereby closes #24. This support includes functionality for handling the WGS 84 ensemble and six specific WGS 84 realisations, including WGS 84 (Transit), WGS 84 (G730), WGS 84 (G873), WGS 84 (G1150), WGS 84 (G1674), WGS 84 (G1762), and WGS 84 (G2139).
General
Several code changes and enhancements effecting multiple programs include:
wgs84
|wgs84 (transit)
|wgs84 (g730)
|wgs84 (g873)
|wgs84 (g1150)
|wgs84 (g1674)
|wgs84 (g1762)
|wgs84 (g2139)
wgs84
is taken to mean the WGS 84 ensemble, whereaswgs84 (xxxx)
is taken to mean any one of the specific WGS 84 realisations (e.g.wgs84 (g2139)
).wgs84
is synonymous withwgs 84
, and both are interpreted case-insensitively.Enhancements to import
--reference-frame
).wgs84
(i.e. the WGS 84 ensemble) is supplied as the default reference frame.Enhancements to reftran
DynAdjust User's Guide
Several changes have been made to reflect the new behaviour, including:
Acknowledgements
Special thanks to Joel Haasdyk for his help in shaping the preferred behaviour for handling WGS 84 data.