Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.2.4 (WGS 84 support) #176

Merged
merged 27 commits into from
Mar 9, 2022
Merged

Version 1.2.4 (WGS 84 support) #176

merged 27 commits into from
Mar 9, 2022

Conversation

rogerfraser
Copy link
Member

Overview

This pull request introduces several enhancements to import and reftran to support handling of the World Geodetic System 1984 (WGS 84) and thereby closes #24. This support includes functionality for handling the WGS 84 ensemble and six specific WGS 84 realisations, including WGS 84 (Transit), WGS 84 (G730), WGS 84 (G873), WGS 84 (G1150), WGS 84 (G1674), WGS 84 (G1762), and WGS 84 (G2139).

General

Several code changes and enhancements effecting multiple programs include:

  • New epsg codes and datum labels for the WGS 84 ensemble and WGS 84 (xxxx), including:
    wgs84 | wgs84 (transit) | wgs84 (g730) | wgs84 (g873) | wgs84 (g1150) | wgs84 (g1674) | wgs84 (g1762) | wgs84 (g2139)
  • wgs84 is taken to mean the WGS 84 ensemble, whereas wgs84 (xxxx) is taken to mean any one of the specific WGS 84 realisations (e.g. wgs84 (g2139)).
  • wgs84 is synonymous with wgs 84, and both are interpreted case-insensitively.
  • Exception handling updated to permit use of the WGS 84 ensemble and WGS 84 (xxxx).

Enhancements to import

  • Permit the use of any one of the WGS 84 datum labels in input DNA and DynaML files, and for the default reference frame (via the command line option --reference-frame).
  • Provide a warning if wgs84 (i.e. the WGS 84 ensemble) is supplied as the default reference frame.
  • Data may be supplied in either the WGS 84 ensemble or WGS 84 (xxxx) with or without an epoch.

Enhancements to reftran

  • Added hard coded substitutions for WGS 84 (xxxx) to ITRFxxxx to facilitate transformation of WGS 84 data to other reference frames. All substitutions are performed prior to undertaking a reference frame transformation.
  • Station coordinate and/or measurement data aligned to WGS 84 without an epoch will cause reftran to terminate prematurely. Data aligned to WGS 84 (xxxx) without an epoch, will cause the associated epoch to be set to the date at which the WGS 84 (xxxx) frame realisation was adopted.
  • Any attempt to transform station coordinates and measurements to WGS 84 will cause reftran to terminate prematurely.

DynAdjust User's Guide

Several changes have been made to reflect the new behaviour, including:

  • 3.3.1 Reference frame receives a general overhaul and a new section entitled "Handling data aligned to WGS 84"
  • Chapter 4 sees various improvements throughout, including
    • Revised epsg codes, and new epsg codes for WGS 84 (xxxx) and WGS 84 ensemble.
    • Updated 4.6.2 Relationship between ITRF, IGS and WGS 84 reference frames.
    • Updated 4.7.1 Progress reporting and import log.

Acknowledgements

Special thanks to Joel Haasdyk for his help in shaping the preferred behaviour for handling WGS 84 data.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage increased (+0.6%) to 81.893% when pulling a6e2cca on 1.2.4 into b9ee808 on master.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #176 (a6e2cca) into master (b9ee808) will decrease coverage by 0.27%.
The diff coverage is 58.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   82.38%   82.10%   -0.28%     
==========================================
  Files         117      118       +1     
  Lines       32531    32961     +430     
==========================================
+ Hits        26800    27064     +264     
- Misses       5731     5897     +166     
Impacted Files Coverage Δ
dynadjust/dynadjust/dnaadjust/dnaadjust.cpp 89.15% <ø> (ø)
dynadjust/dynadjust/dnareftran/dnareftran.hpp 100.00% <ø> (ø)
.../dynadjust/dnareftranwrapper/dnareftranwrapper.cpp 84.61% <0.00%> (-0.51%) ⬇️
dynadjust/include/exception/dnaexception.hpp 77.77% <ø> (ø)
dynadjust/include/functions/dnaprocessfuncs.hpp 100.00% <ø> (ø)
dynadjust/include/io/dnaiosnx.hpp 100.00% <ø> (ø)
dynadjust/include/io/dnaiotpb.cpp 68.08% <ø> (ø)
...ust/include/parameters/dnadatumprojectionparam.hpp 100.00% <ø> (ø)
...st/dynadjust/dnaimportwrapper/dnaimportwrapper.cpp 82.73% <26.66%> (-0.71%) ⬇️
dynadjust/dynadjust/dnareftran/dnareftran.cpp 75.40% <35.63%> (-10.38%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9ee808...a6e2cca. Read the comment docs.

@rogerfraser rogerfraser merged commit 7443f0a into master Mar 9, 2022
@rogerfraser rogerfraser deleted the 1.2.4 branch March 9, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for WGS84 @ epoch
2 participants