Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Once PeterPortal API implements past enrollment data, uncomment the graph modal #182

Closed
ChaseC99 opened this issue Aug 25, 2021 · 6 comments · Fixed by #820
Closed

Once PeterPortal API implements past enrollment data, uncomment the graph modal #182

ChaseC99 opened this issue Aug 25, 2021 · 6 comments · Fixed by #820
Assignees
Labels
codefix Refactoring or improving the codebase low Low priority issue

Comments

@ChaseC99
Copy link
Member

ChaseC99 commented Aug 25, 2021

AntAlmanac used to store past enrollment data and display it in a modal in the EnrollmentGraph component, rendered inside SectionTable. We removed this feature from our API and requested that PeterPortal API implements it (icssc/peterportal-public-api#111). Once they finish, we should put the modal back but still keep the link to ZotTracker.
Reasoning behind moving the data to PeterPortal:

  • Provides this information for all student developers to use
  • Logically it makes sense for PeterPortal API to collect and serve all UCI related data.
  • It will fit nicely into their larger data pipeline plans.
@ChaseC99 ChaseC99 added codefix Refactoring or improving the codebase low Low priority issue labels Oct 1, 2021
@ChaseC99 ChaseC99 self-assigned this Mar 2, 2022
@EricPedley
Copy link
Member

We already did this, right? Safe to close?

@ChaseC99
Copy link
Member Author

We've removed the enrollment data from AntAlmanac but it's not setup on the API yet. You can close this if there's another issue to add the enrollment modal back once it's up on the API

@EricPedley EricPedley changed the title Move enrollment data to PeterPortal API Move past enrollment data to PeterPortal API Jul 17, 2022
@EricPedley
Copy link
Member

So what this issue is talking about is the past enrollment data that used to be stored by us and available in a modal but is now just a link to ZotTracker? Do we have an issue open in PeterPortal API for this?

@ChaseC99
Copy link
Member Author

Correct. Ideally we bring the modal back and add a "View more on ZotTracker" link on the bottom like how we have with grades.

Here's the API Issue for this task: icssc/peterportal-public-api#111

@EricPedley
Copy link
Member

Ok I edited the description of this issue

@EricPedley EricPedley changed the title Move past enrollment data to PeterPortal API Once PeterPortal API implements past enrollment data, uncomment the graph modal Jul 17, 2022
@EricPedley
Copy link
Member

@ecxyzzy when do you think this feature would be ready on the API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codefix Refactoring or improving the codebase low Low priority issue
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants